-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deno: downgrade to 1.43.1 #171382
deno: downgrade to 1.43.1 #171382
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Rui Chen <rui@chenrui.dev> deno: update test Signed-off-by: Rui Chen <rui@chenrui.dev>
926e53f
to
81767d8
Compare
If the root cause is the rust toolchain version 1.78 usage to build Deno, I'm afraid the version downgrade will not be enough. |
seems working fine in my local?
|
Does the resulting binary pass the repro: If yes, then the root cause is narrowed down to rust 1.78 and Deno 1.43.2 code base build. |
yeah, that works with 1.43.1, not 1.43.2 (left a comment in the issue thread as well) env: llvm 18.1.5, rust 1.78.0 |
I don't think @chenrui333 rebuilt |
I did not perform source build (the 1.43.1 was built with llvm 17 as well) we can potentially try this patch for source build with llvm 18, denoland/deno_core#735 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok with merging this for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with this given 1.43.3 will fix this.
Test seems a bit weird and I feel like it could be slimmed down but better than nothing.
thanks, merging! |
that just trying to reproduce the issue for the fresh-project checkout. (deno 1.43.2 just did a partial init, while deno 1.43.1 did the full project init) |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?closes #171317